Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow `/` in pillar includes #52008
What does this PR do?
Re-allows / in pillar includes
What issues does this PR fix or reference?
Commits signed with GPG?
This works but I'm not certain if this works too broadly. For instance, if you wrote:
It would look for
@dwoz not yet - I wanted to make sure that this behavior makes sense before I went and wrote the test for it.
i.e. should all of these be the same as
If the answer is yes, I'll get that test knocked out... otherwise... should I just make it so
@dmurphy18 So... I have some mixed feelings about my current PR.
On the one hand, yes, it does work for allowing
The part I'm questioning is that technically this introduces a new feature, i.e. relative pillar includes. Before, a leading
Should I break this up into multiple PRs, one restoring the behavior, and one with the improvement?