Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Fix to rsync state #52040

Conversation

@garethgreenaway
Copy link
Member

commented Mar 7, 2019

What does this PR do?

When the retcode is non-zero, there are no changes so should include the default empty dictionary.

What issues does this PR fix or reference?

#52036

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…the default empty dictionary.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Mar 7, 2019
@waynew
waynew approved these changes Mar 7, 2019
Copy link
Contributor

left a comment

@garethgreenaway Since this is a bugfix can you write a regression test for the change?

@garethgreenaway

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

@dwoz Done.

…garethgreenaway/salt into 52036_rsync_state_no_changes_when_error
@dwoz
dwoz approved these changes Mar 8, 2019
@garethgreenaway garethgreenaway merged commit a00245e into saltstack:2019.2 Mar 21, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.