Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the dism binary that matches system architecture #52065

Merged
merged 18 commits into from Jul 6, 2019

Conversation

@twangboy
Copy link
Contributor

commented Mar 8, 2019

What does this PR do?

Uses the dism binary that matches the system architecture.

What issues does this PR fix or reference?

#51860

Previous Behavior

Dism module would fail if run from 32bit salt on a 64bit system

New Behavior

Module functions as expected

Tests written?

No

Commits signed with GPG?

Yes

@dwoz
dwoz approved these changes Mar 8, 2019
arizvisa added a commit to arizvisa/lolfuzz3 that referenced this pull request Mar 8, 2019
arizvisa added a commit to arizvisa/lolfuzz3 that referenced this pull request Mar 8, 2019
twangboy added 2 commits Mar 8, 2019
@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@arizvisa Updated with your changes. Thanks!

@twangboy twangboy self-assigned this May 10, 2019
twangboy added 2 commits May 10, 2019
twangboy added 6 commits May 23, 2019
@twangboy twangboy removed the Needs Testcase label Jun 3, 2019
twangboy added 3 commits Jun 3, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 3, 2019
twangboy added a commit that referenced this pull request Jul 5, 2019
Merge Forward #52065 (2019.2.1)
@twangboy twangboy requested a review from saltstack/team-core as a code owner Jul 6, 2019
@pull-assigner pull-assigner bot requested a review from waynew Jul 6, 2019
@twangboy twangboy merged commit 57d8e81 into saltstack:2018.3 Jul 6, 2019
1 of 9 checks passed
1 of 9 checks passed
jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-amazon-2 running py2-amazon-2...
Details
jenkins/pr/py2-centos-6 running py2-centos-6...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-debian-8 running py2-debian-8...
Details
jenkins/pr/py3-amazon-2 running py3-amazon-2...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-debian-8 running py3-debian-8...
Details
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.