Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing symlink test (2018.3) #52145

Merged
merged 2 commits into from Mar 27, 2019

Conversation

@twangboy
Copy link
Contributor

commented Mar 11, 2019

What does this PR do?

Fixes failing test unit.modules.test_win_file.WinFileTestCase.test_issue_52002_check_file_remove_symlink
on Windows
Fixes the test so it cleans up after itself if it fails before the win_file.remove

What issues does this PR fix or reference?

#52103

Tests written?

Yes

Commits signed with GPG?

Yes

@Akm0d Akm0d self-requested a review Mar 27, 2019
@Akm0d
Akm0d approved these changes Mar 27, 2019
@Akm0d Akm0d merged commit 87bb513 into saltstack:2018.3 Mar 27, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy twangboy deleted the twangboy:fix_test_symlink_2018.3 branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.