Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virt whitespace fix #52160

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@cbosdo
Copy link
Contributor

commented Mar 13, 2019

What does this PR do?

Fixes handling of Virtual Machines with white space in their name.

What issues does this PR fix or reference?

None

Previous Behavior

virt.init called with a VM name containing a white space resulted in a failure.

New Behavior

virt.init now works also for VMs with a space in their name.

Tests written?

Yes

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from saltstack/team-core as a code owner Mar 13, 2019
@cbosdo cbosdo changed the base branch from develop to 2019.2 Mar 13, 2019
@cbosdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@rallytime This PR is ready for review

@cbosdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

@rallytime, @thatch45 any news on that PR? How comes it's ACKed but not merged?

The disk creation code is now ready to handle whitespaces in virtual
machine name.
@cbosdo cbosdo force-pushed the cbosdo:virt-whitespace-fix branch from 8168938 to b297e7d Apr 8, 2019
@cbosdo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Just rebased the PR one 2019.2. I hope it'll help to get it merged

@brejoc
brejoc approved these changes Apr 8, 2019
Copy link
Member

left a comment

lgtm

@dwoz dwoz added the 2019.2.1 label Apr 11, 2019
@dwoz dwoz merged commit 80d7aea into saltstack:2019.2 Apr 12, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@cbosdo cbosdo deleted the cbosdo:virt-whitespace-fix branch Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.