Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when task doesn't have delay_random defined #52170

Merged
merged 13 commits into from May 13, 2019

Conversation

@twangboy
Copy link
Contributor

commented Mar 13, 2019

What does this PR do?

Backports the fix for win_task (#47446)
Fixes documentation formatting

What issues does this PR fix or reference?

#44270

Previous Behavior

task.info would fail if the task was missing the RandomDelay parameter.

Tests written?

No

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from saltstack/team-windows Mar 13, 2019
@twangboy twangboy changed the title Fix issue when task doesn't have delay_task parameter Fix issue when task doesn't have delay_random defined Mar 13, 2019
twangboy and others added 2 commits Mar 28, 2019
@twangboy twangboy referenced this pull request Apr 15, 2019
twangboy added 5 commits Apr 15, 2019
…fix_win_task
…fix_win_task
salt/modules/win_task.py Outdated Show resolved Hide resolved
twangboy and others added 5 commits Apr 16, 2019
@twangboy twangboy requested a review from saltstack/team-windows May 10, 2019
@twangboy twangboy self-assigned this May 10, 2019
@twangboy twangboy merged commit 6d8d2f5 into saltstack:2017.7.9 May 13, 2019
9 of 10 checks passed
9 of 10 checks passed
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy twangboy deleted the twangboy:fix_win_task branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.