Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where version doesn't detect when check_remote=True #52191

Merged
merged 6 commits into from May 14, 2019

Conversation

@twangboy
Copy link
Contributor

commented Mar 14, 2019

What does this PR do?

The chocolatey.list function now returns a CaseInsensitiveDict so case is ignored.
Fixes issues where __context__ and __salt__ were being used incorrectly
Optimize the _find_chocolatey function

What issues does this PR fix or reference?

#46150

Tests written?

No

Commits signed with GPG?

Yes

User __context__ correctly
@twangboy twangboy requested a review from saltstack/team-windows Mar 14, 2019
twangboy and others added 2 commits Mar 28, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Apr 12, 2019
dwoz added a commit that referenced this pull request Apr 12, 2019
Bring #52191 into 2019.2 branch
twangboy added 2 commits Apr 17, 2019
@twangboy twangboy self-assigned this May 10, 2019
@s0undt3ch s0undt3ch merged commit c8d8e17 into saltstack:2017.7.9 May 14, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Copy link
Contributor

left a comment

@twangboy Are there tests for this module?

@twangboy twangboy deleted the twangboy:fix_choco branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.