Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 49329 #52212

Merged
merged 1 commit into from Mar 16, 2019

Conversation

@mchugh19
Copy link
Contributor

commented Mar 15, 2019

What does this PR do?

Wraps mkdir operation in test check

What issues does this PR fix or reference?

#49329

Previous Behavior

# salt-call state.single file.append /tmp/foo/bar text="bar" makedirs=True test=True
[ERROR   ] /tmp/foo/bar: file not found
local:
----------
          ID: /tmp/foo/bar
    Function: file.append
      Result: False
     Comment: /tmp/foo/bar: file not found
     Started: 22:11:50.803036
    Duration: 7.558 ms
     Changes:

Summary for local
------------
Succeeded: 0
Failed:    1
------------
Total states run:     1
Total run time:   7.558 ms

Created /tmp/foo directory

New Behavior

# salt-call state.single file.append /tmp/foo/bar text="bar" makedirs=True test=True
local:
----------
          ID: /tmp/foo/bar
    Function: file.append
      Result: None
     Comment: File /tmp/foo/bar is set to be created
     Started: 22:25:49.798269
    Duration: 0.72 ms
     Changes:

Summary for local
------------
Succeeded: 1 (unchanged=1)
Failed:    0
------------
Total states run:     1
Total run time:   0.720 ms

Tests written?

No

Commits signed with GPG?

No

@garethgreenaway garethgreenaway merged commit 0068482 into saltstack:develop Mar 16, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Mar 16, 2019
garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Mar 16, 2019
@mchugh19 mchugh19 deleted the mchugh19:file-state branch Mar 16, 2019
garethgreenaway added a commit that referenced this pull request Mar 21, 2019
Back-port PR #52212 to 2018.3
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PRs to port to master
  
PR needs port to master
2 participants
You can’t perform that action at this time.