Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Don't save beacons when test=True #52213

Merged

Conversation

@garethgreenaway
Copy link
Member

commented Mar 16, 2019

What does this PR do?

Don't save beacons when test=True

What issues does this PR fix or reference?

N/A

Previous Behavior

When test=true beacons would be saved to /etc/salt/minion.d/beacons.conf

New Behavior

When test=True we shouldn't save.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Mar 16, 2019
salt/states/beacon.py Outdated Show resolved Hide resolved
salt/states/beacon.py Outdated Show resolved Hide resolved
@waynew
waynew approved these changes Mar 19, 2019
@dwoz
dwoz approved these changes Mar 29, 2019
@dwoz dwoz merged commit 28f947e into saltstack:2018.3 Mar 29, 2019
9 of 10 checks passed
9 of 10 checks passed
continuous-integration/jenkins/pr-merge This commit is being built
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.