Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GitHub dead link #52276

Merged
merged 4 commits into from Mar 23, 2019

Conversation

@alan-cugler
Copy link
Contributor

commented Mar 21, 2019

What does this PR do?

Adjusted a URL alias in doc page to properly redirect to the salt issues page on github.
The original URL link is valid but the rendered alias redirects in error.
Just stripped some characters from the alias name and it worked properly!

Commits signed with GPG?

Yes

alan-cugler added 2 commits Feb 21, 2019
link for the issue tracker and added a link to show more options
for closing issues in commit messages.
@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

#51750 is the same PR, but I was instructed to make a new one.

Copy link
Collaborator

left a comment

Looked at the rendered markdown and it appears correct.

@twangboy twangboy merged commit 2cdf48e into saltstack:2018.3 Mar 23, 2019
7 of 10 checks passed
7 of 10 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.