New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing a saltenv to slsutil.renderer #52293
Merged
twangboy
merged 4 commits into
saltstack:develop
from
afischer-opentext-com:slsutil_renderer_support_saltenv
Apr 9, 2019
Merged
Support passing a saltenv to slsutil.renderer #52293
twangboy
merged 4 commits into
saltstack:develop
from
afischer-opentext-com:slsutil_renderer_support_saltenv
Apr 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
approved these changes
Mar 23, 2019
What is needed to remove this forward? |
@twangboy, what can I do to increase likelyhood of a merge approval? The last failing test looks like a new test issue (slack integration). |
@waynew Could you please backport this PR to master branch? |
max-arnold
pushed a commit
to max-arnold/salt
that referenced
this issue
Dec 22, 2019
…_renderer_support_saltenv Looks great! Thanks for the code!
Master backport: #55723 |
dwoz
added a commit
that referenced
this issue
Dec 23, 2019
[master] Port #52293 (saltenv support in slsutil.renderer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
There is currently no way to use the module function
slsutil.renderer
for rendering files available on the salts fileserver, which are not available on the base environment, as the parameter for the saltenv is not passed to the method providing the file from the salt fileserver.What issues does this PR fix or reference?
Not filed
Previous Behavior
Both render
salt://path/to/file
from the base environmentNew Behavior
The first call renders the file
salt://path/to/file
available on thesaltenv=base
while the latter renders the file from thesaltenv=banana
Tests written?
No
Commits signed with GPG?
Yes