Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 22, 2019

What does this PR do?

There is currently no way to use the module function slsutil.renderer for rendering files available on the salts fileserver, which are not available on the base environment, as the parameter for the saltenv is not passed to the method providing the file from the salt fileserver.

What issues does this PR fix or reference?

Not filed

Previous Behavior

salt '*' slsutil.renderer salt://path/to/file
salt '*' slsutil.renderer salt://path/to/file saltenv=banana

Both render salt://path/to/file from the base environment

New Behavior

salt '*' slsutil.renderer salt://path/to/file
salt '*' slsutil.renderer salt://path/to/file saltenv=banana

The first call renders the file salt://path/to/file available on the saltenv=base while the latter renders the file from the saltenv=banana

Tests written?

No

Commits signed with GPG?

Yes

@ghost ghost marked this pull request as ready for review March 25, 2019 08:22
@ghost
Copy link
Author

ghost commented Apr 1, 2019

What is needed to remove this forward?

@ghost
Copy link
Author

ghost commented Apr 9, 2019

@twangboy, what can I do to increase likelyhood of a merge approval? The last failing test looks like a new test issue (slack integration).

@twangboy twangboy merged commit 67d5072 into saltstack:develop Apr 9, 2019
@max-arnold
Copy link
Contributor

@waynew Could you please backport this PR to master branch?

max-arnold pushed a commit to max-arnold/salt that referenced this pull request Dec 22, 2019
…_renderer_support_saltenv

Looks great! Thanks for the code!
@max-arnold
Copy link
Contributor

Master backport: #55723

dwoz added a commit that referenced this pull request Dec 23, 2019
[master] Port #52293 (saltenv support in slsutil.renderer)
@garethgreenaway garethgreenaway added the has master-port port to master has been created label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has master-port port to master has been created

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants