Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing a saltenv to slsutil.renderer #52293

Merged
merged 4 commits into from Apr 9, 2019
Merged

Support passing a saltenv to slsutil.renderer #52293

merged 4 commits into from Apr 9, 2019

Conversation

afischer-opentext-com
Copy link
Contributor

@afischer-opentext-com afischer-opentext-com commented Mar 22, 2019

What does this PR do?

There is currently no way to use the module function slsutil.renderer for rendering files available on the salts fileserver, which are not available on the base environment, as the parameter for the saltenv is not passed to the method providing the file from the salt fileserver.

What issues does this PR fix or reference?

Not filed

Previous Behavior

salt '*' slsutil.renderer salt://path/to/file
salt '*' slsutil.renderer salt://path/to/file saltenv=banana

Both render salt://path/to/file from the base environment

New Behavior

salt '*' slsutil.renderer salt://path/to/file
salt '*' slsutil.renderer salt://path/to/file saltenv=banana

The first call renders the file salt://path/to/file available on the saltenv=base while the latter renders the file from the saltenv=banana

Tests written?

No

Commits signed with GPG?

Yes

@afischer-opentext-com afischer-opentext-com marked this pull request as ready for review Mar 25, 2019
@afischer-opentext-com
Copy link
Contributor Author

@afischer-opentext-com afischer-opentext-com commented Apr 1, 2019

What is needed to remove this forward?

@afischer-opentext-com
Copy link
Contributor Author

@afischer-opentext-com afischer-opentext-com commented Apr 9, 2019

@twangboy, what can I do to increase likelyhood of a merge approval? The last failing test looks like a new test issue (slack integration).

@twangboy twangboy merged commit 67d5072 into saltstack:develop Apr 9, 2019
9 of 10 checks passed
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 24, 2019
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Nov 11, 2019

@waynew Could you please backport this PR to master branch?

max-arnold pushed a commit to max-arnold/salt that referenced this issue Dec 22, 2019
…_renderer_support_saltenv

Looks great! Thanks for the code!
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Dec 22, 2019

Master backport: #55723

dwoz added a commit that referenced this issue Dec 23, 2019
[master] Port #52293 (saltenv support in slsutil.renderer)
@garethgreenaway garethgreenaway moved this from PR needs port to master to PR has port to master in PRs to port to master Mar 24, 2020
@garethgreenaway garethgreenaway added the has master-port label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has master-port
Projects
PRs to port to master
  
PR has port to master
Development

Successfully merging this pull request may close these issues.

None yet

4 participants