Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced `test.ping` with `test.version` #52306

Merged
merged 2 commits into from Mar 27, 2019

Conversation

@alan-cugler
Copy link
Contributor

commented Mar 25, 2019

What does this PR do?

Result of issue #52277

Any where test.ping still exists in the docs was left
because it was appropriate in those docs.

Commits signed with GPG?

Yes

Result of issue #52277

Any where `test.ping` still exists in the docs was left
because of the context in those docs.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Mar 25, 2019
@waynew
waynew approved these changes Mar 25, 2019
@waynew

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Man, I <3 this update. The new salt things you learn :)

@highjynks

This comment has been minimized.

Copy link

commented on doc/ref/configuration/index.rst in 0b1eb00 Mar 26, 2019

This needs to be changed as well, either to 2018.3.4 (which might confuse a user with a different version..) or something like "should send a response containing the minion's version, as shown above."

This comment has been minimized.

Copy link
Collaborator Author

replied Mar 26, 2019

thank you for the catch, I will get that fixed

… the version function.
@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Changed the ping text artifact. It should be consistent now unless someone finds another bobo on my part.

@dwoz
dwoz approved these changes Mar 27, 2019
@dwoz dwoz merged commit 14a6b9d into saltstack:2018.3 Mar 27, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.