Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] removing use of comments from incron modules #52345

Conversation

@garethgreenaway
Copy link
Member

commented Mar 27, 2019

What does this PR do?

Updating the incron module, state module and tests to remove use of comments.

What issues does this PR fix or reference?

#52197

Previous Behavior

incron does not support comments and results in error logs when used.

New Behavior

Removing the use of comments in the incrontab.

Tests written?

Yes. Existing tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…omments.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Mar 27, 2019
@waynew
waynew approved these changes Mar 28, 2019
@garethgreenaway garethgreenaway merged commit e88d3ba into saltstack:2018.3 Mar 28, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.