Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #51869 and add cert signing test #52381

Merged
merged 11 commits into from Apr 5, 2019

Conversation

@dwoz
Copy link
Contributor

commented Apr 2, 2019

What does this PR do?

  • Do not publish send args as a string. Instead, use salt.utils.data to convert keys and values of the args dict to strings.
  • Add cert signing test

What issues does this PR fix or reference?

#51869

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

dwoz added 4 commits Apr 2, 2019
@dwoz dwoz force-pushed the dwoz:issue_51869 branch from 46e4236 to a0e2458 Apr 2, 2019
dwoz added 5 commits Apr 2, 2019
@dwoz dwoz changed the title [WIP] Fix issue #51869 and add cert signing test Fix issue #51869 and add cert signing test Apr 2, 2019
@dwoz dwoz added the 2019.2.1 label Apr 5, 2019
@garethgreenaway garethgreenaway merged commit 6bae227 into saltstack:2019.2 Apr 5, 2019
1 check passed
1 check passed
WIP Ready for review
Details
@t0fik t0fik referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.