Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Junos-related bug fixes from develop to 2019.2 #52401

Merged
merged 9 commits into from Jul 6, 2019

Conversation

@rsmekala
Copy link
Contributor

commented Apr 3, 2019

What does this PR do?

Fixes all the junos-related bugs mentioned in #52391. Ported back from develop.

Pull request merged in develop: #51164

What issues does this PR fix or reference?

#52391

Tests written?

Yes

@rsmekala

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@dwoz Can you please look into why the tests are failing ??

@dwoz dwoz added the 2019.2.1 label Apr 5, 2019
@dwoz dwoz changed the base branch from 2019.2 to 2019.2.1 Apr 18, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@dwoz Please do a git reset --hard 211b169 on this and force push the change.

@rsmekala rsmekala force-pushed the rsmekala:2019.2.1 branch from 0ce0c00 to 211b169 Apr 19, 2019
@rsmekala

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@dwoz Updated the branch as requested.

@KChandrashekhar KChandrashekhar requested review from dwoz and waynew Jun 17, 2019
@dwoz
dwoz approved these changes Jul 5, 2019
@waynew
waynew approved these changes Jul 5, 2019
@dwoz dwoz merged commit 1a76e00 into saltstack:2019.2.1 Jul 6, 2019
38 of 40 checks passed
38 of 40 checks passed
ci/py2/amazon2 (ignore-me-new-jenkins) This commit cannot be built
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos6 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1604 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/windows2016 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py2-amazon-2 The py2-amazon-2 job has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-fedora-29 The py2-fedora-29 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-amazon-2 The py3-amazon-2 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.