Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Support for old yaml render #52427

Conversation

@garethgreenaway
Copy link
Member

commented Apr 5, 2019

What does this PR do?

Adding support back in with, a gated configuration option, for the old YAML Loader.

What issues does this PR fix or reference?

#52350

Previous Behavior

With the recent change in 2019.2 to the yaml render, unicode string literals in YAML are no longer supported.

New Behavior

This change added a configuration option to use the older yaml render.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…d YAML Loader.
…l_support
@max-arnold

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

Have you considered using the existing use_superseded configuration namespace for this feature flag?

garethgreenaway and others added 3 commits Apr 8, 2019
…l_support
…l_support
…l_support
@garethgreenaway

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

@max-arnold I looked at using use_superseded but it's designed for individual functions within modules, with this we want to use the older version of the YAMLLoader class.

…l_support
@dwoz
dwoz approved these changes Apr 11, 2019
@dwoz dwoz merged commit 6040282 into saltstack:2019.2 Apr 12, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.