Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018.3 backport #52472 modules.cmdmod: handle windows environ better #52476

Merged
merged 1 commit into from Apr 10, 2019

Conversation

mattp-
Copy link
Contributor

@mattp- mattp- commented Apr 10, 2019

What does this PR do?

backport bugfix #52472

What issues does this PR fix or reference?

see #52472

Tests written?

Yes

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

python exposes an nt.environ for case insensitive environment behavior
that is native to windows; so it makes sense to use this instead of
os.environ to avoid enexpected behavior and failure.

further detail: https://bugs.python.org/issue28824
@dwoz dwoz merged commit 2df74ca into saltstack:2018.3 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants