Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in msgpack >= 0.5.2 (develop) #52487

Open

Conversation

@terminalmage
Copy link
Contributor

commented Apr 10, 2019

This prevents a deprecation warning due to the "encoding" argument being deprecated in version 0.5.2.

[WARNING ] /home/erik/git/salt/saltdev/salt/payload.py:149: DeprecationWarning: encoding is deprecated, Use raw=False instead.
  ret = msgpack.loads(msg, use_list=True, ext_hook=ext_type_decoder, encoding=encoding)
This prevents a deprecation warning due to the "encoding" argument being
deprecated in version 0.5.2.
@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Apr 10, 2019
@Ch3LL Ch3LL referenced this pull request Apr 25, 2019
@twangboy twangboy closed this Jun 25, 2019
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Was this not needed due to merge-forwards? I opened this at the same time as the other PR to in-advance handle the merge conflict.

@waynew waynew reopened this Jun 26, 2019
@waynew

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

I suspect that was accidental, though @twangboy can weigh in if needed. His GitHub has been occasionally causing him some problems, I've noticed :trollface:

@Ch3LL Ch3LL requested a review from twangboy Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.