Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in msgpack >= 0.5.2 (2018.3) #52488

Merged
merged 7 commits into from Apr 29, 2019

Conversation

@terminalmage
Copy link
Contributor

commented Apr 10, 2019

NOTE: THIS WILL CONFLICT ONCE MERGED INTO DEVELOP (SEE #52487) DUE TO SALT.UTILS.MSGPACK BEING NEW IN THAT BRANCH. MERGE #52487 BEFORE THIS PR IS MERGED FORWARD INTO DEVELOP.

This prevents a deprecation warning due to the "encoding" argument being deprecated in version 0.5.2.

[WARNING ] /home/erik/git/salt/saltdev/salt/payload.py:149: DeprecationWarning: encoding is deprecated, Use raw=False instead.
  ret = msgpack.loads(msg, use_list=True, ext_hook=ext_type_decoder, encoding=encoding)
This prevents a deprecation warning due to the "encoding" argument being
deprecated in version 0.5.2.
@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Apr 10, 2019
dwoz added 6 commits Apr 11, 2019
@dwoz
dwoz approved these changes Apr 29, 2019
@dwoz dwoz merged commit 8b628a1 into saltstack:2018.3 Apr 29, 2019
16 checks passed
16 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1404 The py2-ubuntu-1404 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.