Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback when invalid source passed to archive.extracted #52500

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@terminalmage
Copy link
Contributor

commented Apr 11, 2019

When the source is procedurally generated (e.g. from the result of a
remote execution function call), and that source ends up being an empty
string or some other invalid value, the call to file.source_list will
return a path of None which will cause a TypeError later on when we
try to run a urlparse on it.

When the source is procedurally generated (e.g. from the result of a
remote execution function call), and that source ends up being an empty
string or some other invalid value, the call to `file.source_list` will
return a path of `None` which will cause a `TypeError` later on when we
try to run a urlparse on it.
@twangboy twangboy merged commit 6e79e24 into saltstack:2018.3 Apr 11, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.