Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virt purge fix #52548

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@cbosdo
Copy link
Contributor

commented Apr 15, 2019

What does this PR do?

Fixes Exception: unsupported flags (0x4) in function libxlDomainUndefineFlags thrown when running virt.purge on non-QEMU hypervisor.

What issues does this PR fix or reference?

Fixes issue #52547

Previous Behavior

Running virt.purge test-vm on a Xen hypervisor raised an exception due to unhandled flag

New Behavior

Running virt.purge test-vm on a Xen hypervisor just works

Tests written?

No: catching up such errors would require integration tests with real libvirt on various hypervisors.

Commits signed with GPG?

Yes

(cherry picked from commit 29a44ac)
@cbosdo cbosdo requested a review from saltstack/team-core as a code owner Apr 15, 2019
@cbosdo cbosdo changed the base branch from develop to 2019.2 Apr 15, 2019
@cbosdo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@rallytime @dwoz this PR is ready for review.

@dwoz dwoz changed the base branch from 2019.2 to 2019.2.1 Apr 18, 2019
@dwoz
dwoz approved these changes Apr 18, 2019
@dwoz dwoz merged commit 8ee15a9 into saltstack:2019.2.1 Apr 18, 2019
10 of 11 checks passed
10 of 11 checks passed
codeclimate 36 issues to fix
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@cbosdo cbosdo deleted the cbosdo:virt-purge-fix branch Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.