Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #51842 #52553

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@mattLLVW
Copy link
Contributor

commented Apr 15, 2019

What does this PR do?

Fix #51842 Wrong model name

What issues does this PR fix or reference?

#51842

@mattLLVW mattLLVW requested a review from saltstack/team-core as a code owner Apr 15, 2019
minion_fn = models.CharField()
user_fk = models.ForeignKey(User, on_delete=models.CASCADE)
minion_or_fn_matcher = models.CharField(max_length=255)
minion_fn = models.CharField(max_length=255)

This comment has been minimized.

Copy link
@waynew

waynew Apr 15, 2019

Contributor

If there's an assumption of Postgres as the database, there's no reason to add max_length.

This comment has been minimized.

Copy link
@waynew

This comment has been minimized.

Copy link
@waynew
@waynew
waynew approved these changes Apr 15, 2019
Copy link
Contributor

left a comment

@mattLLVW Is it possible to add a test for this change?

@mattLLVW

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

It's a documentation change...?

@dwoz
dwoz approved these changes Apr 17, 2019
Copy link
Contributor

left a comment

@mattLLVW My bad I took a glance and it looked like a code change. Approved.

@dwoz dwoz merged commit 8352362 into saltstack:2019.2 Apr 17, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@mattLLVW mattLLVW deleted the mattLLVW:fix_django_auth_docs branch Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.