Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IPCClient and prevent corrupt messages (Turn 2) #52564

Merged
merged 5 commits into from Apr 18, 2019

Conversation

@DmitryKuzmenko
Copy link
Contributor

commented Apr 16, 2019

What does this PR do?

Since we decided to remove singletons from IPC transport I've reverted my approach implementing the subscriber pattern as a local singleton service and multiple subscribers for it because if we don't need singleton we can just be subscribers.
Also I've removed singleton from the reverted subscriber and slightly simplified the code (in comparison to the original one, before mine and @dwoz fixes)

What issues does this PR fix or reference?

Reverts #51963
Related to #52445

Tests written?

Yes (I haven't reverted the tests because them are useful)

Commits signed with GPG?

Yes

@dwoz

This comment has been minimized.

@DmitryKuzmenko DmitryKuzmenko force-pushed the DSRCorporation:bugs/revert_51963 branch from 8afbcb6 to 7696617 Apr 16, 2019
This reverts commit 37aeba3.
This reverts commit 684bf58.
…e process"

This reverts commit 710ab50.
@dwoz
dwoz approved these changes Apr 18, 2019
@dwoz dwoz merged commit e38fadd into saltstack:2018.3 Apr 18, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.