Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge forward 2019.3 to develop #52571

Closed

Conversation

DmitryKuzmenko
Copy link
Contributor

What does this PR do?

Here's Merge forward from 2019.3 + #52564 to develop branch.

What issues does this PR fix or reference?

Merge forward!

garethgreenaway and others added 30 commits February 28, 2019 13:18
…us test state functions as they are valid arguments for mod_watch.
…ecause test=True, but could be changed by other states.
The integer was causing the .replace('_', '-') function to fail
…missions are shown and not the octal number.
https://gist.github.com/s0undt3ch/9298a69a3492404d89a832de9efb1e68

This only happens when XML reporting is enabled.
Why only now, I have no clue.
This is also removing the use of dev_*.ps1 scripts in the windows builds
Use windows state to bootstrap windows builds
…h.search_by when used in pillar broke when targetting the minion that was also the salt master. This was caused by the id in __opts__ being used in all cases. This change updates the glob_match function to use the preserved minion_id of the master if it is available so that targeting works as expected.
Make the domain grain match the windowsdomain grain on Windows
dwoz and others added 18 commits April 11, 2019 16:57
…result_comment_changes_valid_arguments

[2019.2] Fix to test state functions to allow arguments that mod_watch uses
…earch_by_master

[2019.2] Fixes to matchers when used in pillar
…nd_gate_unicode_string_literal_support

[2019.2] Support for old yaml render
fix missing client_args in influxdb module
…r-return-error

51879 fix binary pillar return error
@DmitryKuzmenko DmitryKuzmenko requested a review from a team as a code owner April 17, 2019 01:17
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows stuff looks good

@DmitryKuzmenko
Copy link
Contributor Author

This one is outdated and it's easier to create a new one that rebase this one.
#52729 replaces this PR.

@DmitryKuzmenko DmitryKuzmenko deleted the bugs/revert_51963_develop branch October 23, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet