Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Update test_schema to mirror the new ValidationErrors in 3.0.0 #52591

merged 1 commit into from Apr 18, 2019


Copy link

commented Apr 17, 2019

Brings changes from #52588 to 2019.2.1

What does this PR do?

Fixes the failing tests: unit.utils.test_schema

In jsonschema version 3.0.0 the validation errors were updated to grab the best match, instead of the default is not valid under any of the given schemas in this commit: Julian/jsonschema@17fb9cb

to fix this issue: Julian/jsonschema#498

This updates the tests to check for the error's with more detail when testing with >= 3.0.0

What issues does this PR fix or reference?

Fixes #52085

Tests written?

No- Fixes current tests failing on osx

Commits signed with GPG?


dwoz approved these changes Apr 18, 2019
@dwoz dwoz merged commit e03aed5 into saltstack:2019.2.1 Apr 18, 2019
5 checks passed
5 checks passed
WIP Ready for review
continuous-integration/jenkins/pr-merge This commit looks good
jenkins/pr/docs The docs job has passed
jenkins/pr/lint Python lint test has passed
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.