Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #52593

Open
wants to merge 4 commits into
base: 2018.3
from

Conversation

@twangboy
Copy link
Contributor

commented Apr 17, 2019

What does this PR do?

Syncs all locations where scripts are defined to have the following:

  • salt-call
  • salt-cp
  • salt-minion
  • salt-syndic
  • salt-unity
  • spm

Fixes some salt-proxy tests, need to figure out the rest before we can add back salt-proxy
Adds spm
Fix some issues in case.py where timeout was defined but not used

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz
dwoz approved these changes Apr 17, 2019
@twangboy twangboy self-assigned this May 10, 2019
@twangboy twangboy added the Neon label Jun 14, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 3, 2019
twangboy added 2 commits Apr 17, 2019
Syncs all locations where scripts are defined to have the following:
- salt-call
- salt-cp
- salt-minion
- salt-syndic
- salt-unity
- spm
Fix some salt-proxy tests, need to figure out the rest before we can add
back salt-proxy
Add spm
Fix some issues in case.py where timeout was defined but not used
@twangboy twangboy force-pushed the twangboy:fix_setup branch from 6359202 to 9e7821c Jul 3, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #52593 into 2018.3 will decrease coverage by 29.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           2018.3   #52593       +/-   ##
===========================================
- Coverage   37.31%    8.01%   -29.31%     
===========================================
  Files        1512      593      -919     
  Lines      257084    94517   -162567     
  Branches    55053    21683    -33370     
===========================================
- Hits        95939     7574    -88365     
+ Misses     150071    85898    -64173     
+ Partials    11074     1045    -10029
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 ?
#debian9 ?
#m2crypto ?
#proxy ?
#py2 7.83% <ø> (-29.25%) ⬇️
#py3 7.85% <ø> (-28.19%) ⬇️
#pycryptodomex ?
#raet ?
#tornado ?
#ubuntu1604 ?
#windows2016 8.01% <ø> (?)
Impacted Files Coverage Δ
salt/states/stateconf.py 0% <0%> (-100%) ⬇️
salt/states/disk.py 0% <0%> (-100%) ⬇️
salt/executors/__init__.py 0% <0%> (-100%) ⬇️
salt/renderers/__init__.py 0% <0%> (-100%) ⬇️
salt/states/__init__.py 0% <0%> (-100%) ⬇️
salt/states/pagerduty.py 0% <0%> (-100%) ⬇️
salt/serializers/python.py 0% <0%> (-100%) ⬇️
salt/tops/__init__.py 0% <0%> (-100%) ⬇️
salt/states/pkgng.py 0% <0%> (-100%) ⬇️
salt/utils/yamlencoding.py 0% <0%> (-100%) ⬇️
... and 1444 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4671a1...9e7821c. Read the comment docs.

twangboy added a commit that referenced this pull request Jul 5, 2019
Merge Forward #52593 (2019.2.1)
@twangboy twangboy requested a review from saltstack/team-core as a code owner Jul 6, 2019
@pull-assigner pull-assigner bot requested a review from xeacott Jul 6, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 25, 2019
@twangboy twangboy referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.