Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event assertion race condition #52629

Merged
merged 2 commits into from Apr 19, 2019

Conversation

@dwoz
Copy link
Contributor

commented Apr 19, 2019

What does this PR do?

Fix race condition in event received assertion

See also #52540

Previous Behavior

Test could run before event bus is connected and receiving events

New Behavior

Wait for the event bus to connect before running test

Tests written?

No - Fixing test flakiness

Commits signed with GPG?

Yes

dwoz added 2 commits Apr 19, 2019
@Ch3LL
Ch3LL approved these changes Apr 19, 2019
@Ch3LL Ch3LL merged commit 0a4d2d9 into saltstack:2019.2.1 Apr 19, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.