Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with the win_file tests #52659

Merged
merged 1 commit into from Apr 22, 2019

Conversation

@twangboy
Copy link
Contributor

commented Apr 22, 2019

What does this PR do?

Fixes the failing branch tests https://jenkinsci.saltstack.com/job/pr-kitchen-windows2016-py2/job/PR-52633/1/#showFailuresLink

Removes pchanges
Mocks __utils__['dacl.*'] instead of win_file.check_perms

Tests written?

Yes

Commits signed with GPG?

Yes

Remove pchanges
Migrate to __utils__['dacl.check_perms']
@dwoz
dwoz approved these changes Apr 22, 2019
@dwoz dwoz merged commit 174f558 into saltstack:2019.2.1 Apr 22, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy twangboy deleted the twangboy:fix_test_win_file branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.