Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_gen_thin_compression_fallback_py3 #52753

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@twangboy
Copy link
Contributor

commented Apr 29, 2019

What does this PR do?

Skips test_gen_thin_compression_fallback_py3 on Windows running Python 2. This test is causing python to hard crash, thus killing the entire test suite.

image

It dies on utils/thin.py: 456:

        tfp = tarfile.open(tmp_thintar, 'w:gz', dereference=True)

It doesn't die when working with this salt util directly, only when run from the test suite.

Also simplifies the _get_thintar_prefix function

Issue referenced

#52720

Tests written?

No

Commits signed with GPG?

Yes

Skips this test on Windows running Python 2
This test is causing python to hard crash, thus killing the entire test
suite
Also simplifies the _get_thintar_prefix function
@twangboy twangboy requested review from isbm and saltstack/team-core Apr 29, 2019
@dwoz
dwoz approved these changes Apr 30, 2019
@dwoz dwoz merged commit 3e46f51 into saltstack:2019.2.1 Apr 30, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy twangboy deleted the twangboy:skip_test_gen_thin branch Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.