Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non raw msg pack msg decoding #52755

Merged
merged 4 commits into from Apr 30, 2019

Conversation

@dwoz
Copy link
Contributor

commented Apr 30, 2019

What does this PR do?

Fixing some tests that broke after merging #52488

Tests that failed:

integration.modules.test_state.StateModuleTest.test_state_sls_unicode_characters
integration.modules.test_state.StateModuleTest.test_state_sls_unicode_characters_cmd_output
integration.modules.test_state_jinja_filters.StateModuleJinjaFiltersTest.test_json
integration.modules.test_state_jinja_filters.StateModuleJinjaFiltersTest.test_yaml
integration.states.test_file.FileTest.test_issue_8947_utf8_sls

** Wait for the full test suites to run before merging **

Tests written?

Yes

Commits signed with GPG?

Yes

dwoz added 2 commits Apr 30, 2019
@dwoz dwoz requested a review from saltstack/team-core as a code owner Apr 30, 2019
@waynew
waynew approved these changes Apr 30, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

re-run full all

@dwoz dwoz merged commit d6a71a9 into saltstack:2018.3 Apr 30, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-merge This commit is being built
Details
WIP Ready for review
Details
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 25, 2019
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 25, 2019
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 25, 2019
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 27, 2019
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.