Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_file_managed_should_fall_back_to_binary on Windows #52770

merged 4 commits into from May 9, 2019


Copy link

commented Apr 30, 2019

What does this PR do?

Fixes unit.states.test_file.TestFileState.test_file_managed_should_fall_back_to_binary by pass encoding to _validate_str_list and forwarding that on to to_unicode... basically forcing utf-8, which actually fails in the to_unicode function, but returns the value we want.... so not sure what intended behavior is here.

Also, removes deprecated import

What issues does this PR fix or reference?


Tests written?


Commits signed with GPG?


twangboy and others added 3 commits Apr 30, 2019
@twangboy twangboy merged commit 20cccd8 into saltstack:2019.2.1 May 9, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-merge This commit is being built
WIP Ready for review
@twangboy twangboy deleted the twangboy:fix_test_file branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.