Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #50400 and #50402 into 2019.2.1 #52796

Merged
merged 4 commits into from May 10, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented May 2, 2019

What does this PR do?

Backport #50400 and #50402 into 2019.2.1

xuhcc added 2 commits Nov 6, 2018
Fixes #50310
@garethgreenaway

This comment has been minimized.

Copy link
Member

commented May 2, 2019

re-run windows

s0undt3ch and others added 2 commits May 9, 2019
@Ch3LL Ch3LL requested a review from saltstack/team-core May 10, 2019
@twangboy twangboy merged commit cae51c2 into saltstack:2019.2.1 May 10, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@dstensnes

This comment has been minimized.

Copy link

commented on salt/modules/acme.py in 9be5c0c Jul 24, 2019

@Ch3LL typo?

This comment has been minimized.

Copy link

replied Jul 24, 2019

sorry, never mind. Thought I was in the saltstack/salt repository, but it appears to be correct there...

This comment has been minimized.

Copy link
Owner

replied Jul 24, 2019

yeah there is a follow up PR that i backported alongside this one that fixes the typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.