support args in unless and onlyif #52969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3LL
approved these changes
May 14, 2019
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 13, 2019
support args in unless and onlyif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
support args in unless and onlyif requisites module parsing
also document in release notes
Previous Behavior
Neon functionality enhancing onlyif and unless only works with execution modules supporting kwargs
New Behavior
Now execution modules run through onlyif or unless can support modules with args
Also includes release note
Tests written?
Yes
Commits signed with GPG?
No
@gtmanfred