Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support args in unless and onlyif #52969

Merged
merged 2 commits into from May 14, 2019
Merged

support args in unless and onlyif #52969

merged 2 commits into from May 14, 2019

Conversation

mchugh19
Copy link
Contributor

@mchugh19 mchugh19 commented May 10, 2019

What does this PR do?

support args in unless and onlyif requisites module parsing
also document in release notes

Previous Behavior

Neon functionality enhancing onlyif and unless only works with execution modules supporting kwargs

New Behavior

Now execution modules run through onlyif or unless can support modules with args
Also includes release note

Tests written?

Yes

Commits signed with GPG?

No

@gtmanfred

Copy link
Contributor

@gtmanfred gtmanfred left a comment

nice tests!

Ch3LL
Ch3LL approved these changes May 14, 2019
@Ch3LL Ch3LL merged commit 21552ac into saltstack:develop May 14, 2019
10 of 11 checks passed
mchugh19 pushed a commit to mchugh19/salt that referenced this issue Oct 13, 2019
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 17, 2019
@waynew waynew added the has master-port label Oct 17, 2019
@waynew waynew moved this from PR needs port to master to PR has port to master in PRs to port to master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has master-port
Projects
PRs to port to master
  
PR has port to master
Development

Successfully merging this pull request may close these issues.

None yet

4 participants