Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ssh tops log message to debug #53020

Merged
merged 2 commits into from May 14, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented May 14, 2019

What does this PR do?

In the 2019.2 releases a new log message was added when attempting to compile all of the tops. Previously there was not a log message and that's why we are seeing this now. Not everyone that is using salt-ssh is going to want to use both python2 and python3, so I think its better to have this log as a debug message instead. If this is an error most salt-ssh users will see this error message on first run of their salt-ssh command if they do not have salt dependencies installed for both python2 and python3 on their host. The error could also be misleading to let them think there is an issue with their environment when in reality there is not and they can still use salt-ssh. Moving it to debug will still provide the information for users that are trying to use both python versions.

What issues does this PR fix or reference?

#52637

Previous Behavior

(salt-py2) ➜  salt git:() sudo salt-ssh 'localhost' test.ping
[ERROR   ] Failed collecting tops for Python binary python3.
localhost:
    True

New Behavior

(salt-py2) ➜  salt git:() sudo salt-ssh 'localhost' test.ping
localhost:
    True

And on debug log level you will see the message now.

Tests written?

No - cosmetic change. If tests are still required for cosmetic changes i can write one.

Commits signed with GPG?

Yes

Ch3LL added 2 commits May 14, 2019
@dwoz
dwoz approved these changes May 14, 2019
@dwoz dwoz merged commit c56fbb0 into saltstack:2019.2.1 May 14, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.