-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt.modules.network: Add functions to get minion's networks #53100
Conversation
@terminalmage Looks like have some lint |
@twangboy That was a false positive, I've pushed an update that ignores that particular failure. |
@terminalmage looks like there is a merge conflict, would you be willing to fix that? also, i plan on creating the neon branch today, i will migrate this PR to the new branch after its created thanks :) |
Rebased. |
FYI I migrated this PR from develop to neon to ensure it is included in the upcoming neon release. Let me know if this caused any issues. Thanks |
@Ch3LL It looked fine to me. I noticed a docstring that had IPv4 instead of IPv6 in it, so I fixed that and rebased, and re-ran tests. They look good to me so I pushed. Assuming tests pass I think this is good to merge. |
3a662aa
to
fc7c807
Compare
I've rebased and re-pointed at |
d2bdf0f
to
0212ca1
Compare
Rebased again. Any chance we can get this merged? |
76c8341
to
ea387dc
Compare
Can we get this re-reviewed and try to get it merged? It has been nearly 11 months. |
@terminalmage thanks for rebasing this, I've also blackened it for you. Could you please address the lint issues? |
One of the lint warnings was due to black itself inserting a comma. Both warnings should now be fixed. |
695baad
to
a995eb0
Compare
Rebased again. |
What does this PR do?
Two new functions added which return information about the networks to which the minion belongs. Additionally, the
interface
arg to both new functions supports multiple interfaces and globbing. This additional functionality has also been added to theip_addrs
andip_addrs6
functions, and all four of these functions now use common code for filtering the interface data. DRY.What issues does this PR fix or reference?
N/A
Tests written?
Yes
Commits signed with GPG?
No