Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] newer msgpack ipc fixes #53242

Merged
merged 5 commits into from Jun 3, 2019

Conversation

@s0undt3ch
Copy link
Member

commented May 25, 2019

What does this PR do?

Re-submit #52934 fixed after being reverted in #52755

What issues does this PR fix or reference?

#52934, #52755, #52487

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

Only merge after re-running all full tests

@s0undt3ch s0undt3ch requested review from twangboy and dwoz May 25, 2019
@dwoz
dwoz approved these changes May 25, 2019
@s0undt3ch s0undt3ch changed the title [2019.2.1] newermsgpack ipc fixes [2019.2.1] newer msgpack ipc fixes May 25, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

This is not the only required change and I can't devote more time to this right now.

@s0undt3ch s0undt3ch changed the title [2019.2.1] newer msgpack ipc fixes [WIP] [2019.2.1] newer msgpack ipc fixes May 25, 2019
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/msgpack-ipc-2019.2.1 branch from a81ad25 to 7c71cc6 May 25, 2019
@s0undt3ch s0undt3ch requested a review from saltstack/team-core as a code owner May 27, 2019
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/msgpack-ipc-2019.2.1 branch 2 times, most recently from 023ee44 to 110ccf8 May 27, 2019
@s0undt3ch s0undt3ch changed the title [WIP] [2019.2.1] newer msgpack ipc fixes [2019.2.1] newer msgpack ipc fixes May 27, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

I think I got it to properly work under Py2 and Py3.

@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/msgpack-ipc-2019.2.1 branch from 7a96dbf to 5ec4a04 May 27, 2019
@s0undt3ch s0undt3ch requested a review from dwoz May 27, 2019
twangboy and others added 3 commits May 7, 2019
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/msgpack-ipc-2019.2.1 branch from 5ec4a04 to 0ae2ef0 May 27, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

re-run full all

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

re-run full all

@twangboy twangboy merged commit ce5d79a into saltstack:2019.2.1 Jun 3, 2019
16 of 17 checks passed
16 of 17 checks passed
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.