Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Switch docs building under Py3 #53273

Merged

Conversation

@s0undt3ch
Copy link
Member

commented May 28, 2019

What does this PR do?

See title.

What issues does this PR fix or reference?

#53137

@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/py3-nox-docs-2019.2.1 branch from c3f2641 to af3af08 May 28, 2019
@s0undt3ch s0undt3ch requested a review from saltstack/team-core as a code owner May 28, 2019
@s0undt3ch s0undt3ch requested a review from bryceml May 28, 2019
@Akm0d
Akm0d approved these changes May 28, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

re-run full all

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Hold off on merging, @bryceml point out a missing flag that should be passed to Sphinx.
Also, why do you want to re-run the full test suite for a docs build change?

s0undt3ch added 3 commits May 28, 2019
Refs #53137
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/py3-nox-docs-2019.2.1 branch from af3af08 to 98653c0 May 29, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

We're good to go again if docs builds pass

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

re-run all full

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

Approved and tests pass, merging.

@s0undt3ch s0undt3ch merged commit 1cf57e9 into saltstack:2019.2.1 Jun 5, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.