Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops pylint E1120 from showing #53289

Merged

Conversation

@cmcmarrow
Copy link
Contributor

commented May 28, 2019

What does this PR do?

silences pylint E1120(no-value-for-parameter)

I don't believe there is a good way to fix this pylint warring. pylint is complaining about a method in a 3rd party library. The 3rd party library did nothing wrong. We add it default arguments to methods in the 3rd party library.

What issues does this PR fix or reference?

#53285

Tests written?

No

Commits signed with GPG?

Yes

cmcmarrow added 3 commits May 28, 2019
@Akm0d Akm0d self-requested a review May 30, 2019
@Akm0d
Akm0d approved these changes May 30, 2019
tests/unit/modules/test_kubernetesmod.py Outdated Show resolved Hide resolved
@cmcmarrow cmcmarrow force-pushed the cmcmarrow:test_kubernetes_lint_failures_silenced branch from 74cf318 to cbe6423 May 31, 2019
@cmcmarrow cmcmarrow requested review from twangboy and Akm0d May 31, 2019
@Akm0d
Akm0d approved these changes May 31, 2019
@cmcmarrow cmcmarrow merged commit df448c2 into saltstack:2019.2.1 Jun 1, 2019
11 of 16 checks passed
11 of 16 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP Ready for review
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.