Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename shadow to linux_shadow for consistency #53296

Closed
wants to merge 5 commits into from

Conversation

gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented May 29, 2019

What does this PR do?

Right now, the docs for shadow.rst just talk about there being a shadow module, but it is impossible to see the shadow docs for linux. This moves the linux module to linux_shadow.py and links them

Commits signed with GPG?

Yes

And easy documentation purposes.
@Ch3LL Ch3LL requested a review from waynew Jun 14, 2019
waynew
waynew approved these changes Sep 18, 2019
@dwoz dwoz requested a review from as a code owner Apr 11, 2020
@ghost ghost requested a review from cmcmarrow Apr 11, 2020
@dwoz
Copy link
Contributor

@dwoz dwoz commented Apr 11, 2020

This needs to go to the master branch.

@dwoz dwoz removed the Merge Ready label Apr 11, 2020
@Ch3LL Ch3LL removed the request for review from Apr 15, 2020
@cmcmarrow
Copy link
Contributor

@cmcmarrow cmcmarrow commented Jun 8, 2020

Hi, @gtmanfred. This still needs to go into the master branch. Thank you for the tests and the PR!

@cmcmarrow cmcmarrow added the Test-Failure label Jun 8, 2020
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jun 9, 2020

@cmcmarrow I believe this PR can be closed, because it is already included in #55914 that was merged a while ago.

@gtmanfred gtmanfred closed this Jun 9, 2020
@gtmanfred gtmanfred deleted the 2018.3 branch Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants