Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] The TCP transport needs the exact same requirements as the ZeroMQ one #53297

Merged
merged 1 commit into from May 30, 2019

Conversation

@s0undt3ch
Copy link
Member

commented May 29, 2019

What does this PR do?

The TCP transport needs the exact same requirements as the ZeroMQ one

10:38:21          test_down (integration.runners.test_manage.ManageTest) ... 09:37:29,619 [salt.minion                                               :3064][CRITICAL] Unexpected error while connecting to localhost
10:38:21        Traceback (most recent call last):
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 3036, in _connect_syndic
10:38:21            yield syndic.connect_master(failed=failed)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1055, in run
10:38:21            value = future.result()
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/concurrent.py", line 238, in result
10:38:21            raise_exc_info(self._exc_info)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1063, in run
10:38:21            yielded = self.gen.throw(*exc_info)
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 1218, in connect_master
10:38:21            master, self.pub_channel = yield self.eval_master(self.opts, self.timeout, self.safe, failed)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1055, in run
10:38:21            value = future.result()
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/concurrent.py", line 238, in result
10:38:21            raise_exc_info(self._exc_info)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 307, in wrapper
10:38:21            yielded = next(result)
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 713, in eval_master
10:38:21            pub_channel = salt.transport.client.AsyncPubChannel.factory(self.opts, **factory_kwargs)
10:38:21          File "/tmp/kitchen/testing/salt/transport/client.py", line 161, in factory
10:38:21            import salt.transport.zeromq
10:38:21          File "/tmp/kitchen/testing/salt/transport/zeromq.py", line 41, in <module>
10:38:21            import zmq.error
10:38:21        ImportError: No module named zmq.error

What issues does this PR fix or reference?

```
10:38:21          test_down (integration.runners.test_manage.ManageTest) ... 09:37:29,619 [salt.minion                                               :3064][CRITICAL] Unexpected error while connecting to localhost
10:38:21        Traceback (most recent call last):
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 3036, in _connect_syndic
10:38:21            yield syndic.connect_master(failed=failed)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1055, in run
10:38:21            value = future.result()
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/concurrent.py", line 238, in result
10:38:21            raise_exc_info(self._exc_info)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1063, in run
10:38:21            yielded = self.gen.throw(*exc_info)
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 1218, in connect_master
10:38:21            master, self.pub_channel = yield self.eval_master(self.opts, self.timeout, self.safe, failed)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 1055, in run
10:38:21            value = future.result()
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/concurrent.py", line 238, in result
10:38:21            raise_exc_info(self._exc_info)
10:38:21          File "/tmp/kitchen/testing/.nox/runtests-parametrized-2-7-coverage-true-crypto-none-transport-tcp/lib/python2.7/site-packages/tornado/gen.py", line 307, in wrapper
10:38:21            yielded = next(result)
10:38:21          File "/tmp/kitchen/testing/salt/minion.py", line 713, in eval_master
10:38:21            pub_channel = salt.transport.client.AsyncPubChannel.factory(self.opts, **factory_kwargs)
10:38:21          File "/tmp/kitchen/testing/salt/transport/client.py", line 161, in factory
10:38:21            import salt.transport.zeromq
10:38:21          File "/tmp/kitchen/testing/salt/transport/zeromq.py", line 41, in <module>
10:38:21            import zmq.error
10:38:21        ImportError: No module named zmq.error
```
@waynew
waynew approved these changes May 29, 2019
@rares-pop

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Is it that just the TCP tests depend on zmq? Or the whole salt when it's configured to use 'tcp'?

It would be nice to clear the dependencies, as opposed to hide them even further.

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

If you look closely at the traceback you'll see that it's salt that requires ZMQ even if the TCP transport is selected.

Also, this is not an attempt at hiding that, this is us resuming the previous working test configuration(dependencies) so that we can keep getting accurate test results, at least, as accurate as they were before.

I'm not discarding the fact that, ideally, Salt should not depend on ZMQ for the TCP transport, but, that ideal scenario, at least so far, is out of the scope of the 2029.2.1 release.

@garethgreenaway garethgreenaway self-requested a review May 30, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

There are no code changes and the failures are the same as in the branch builds.

@s0undt3ch s0undt3ch merged commit d359513 into saltstack:2019.2.1 May 30, 2019
13 of 17 checks passed
13 of 17 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@s0undt3ch s0undt3ch deleted the s0undt3ch:hotfix/tcp-transport-tests branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.