Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully qualified cmd call #53311

Merged
merged 8 commits into from Jun 17, 2019

Conversation

@doesitblend
Copy link
Contributor

commented May 30, 2019

What does this PR do?

Add full path to the CMD.exe call when creating a scheduled task to restart the Salt minion on Windows

What issues does this PR fix or reference?

Fixes #53306

Previous Behavior

Full path to the CMD command was not used causing some vulnerability scanners to list the Salt minion as a potential threat.

Tests written?

No

Commits signed with GPG?

Yes/No

s0undt3ch and others added 4 commits May 28, 2019
[2019.2.1] Minion blackout tests - Add the missing, and required, top pillar file
@doesitblend doesitblend requested a review from twangboy May 30, 2019
@doesitblend doesitblend self-assigned this May 30, 2019
twangboy and others added 3 commits May 31, 2019
@twangboy twangboy merged commit 12c769a into saltstack:develop Jun 17, 2019
18 checks passed
18 checks passed
WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
twangboy added a commit to twangboy/salt that referenced this pull request Jul 26, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 26, 2019
dwoz added a commit that referenced this pull request Aug 9, 2019
Backport #53311 to 2019.2.1
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.