kubeadm: add initial module for kubeadm#53345
Merged
dwoz merged 1 commit intosaltstack:masterfrom May 18, 2020
Merged
Conversation
Contributor
Author
|
Ready for reviews |
aplanas
force-pushed
the
fix_kubeadm
branch
2 times, most recently
from
383166b to
e531992
Compare
Contributor
Author
|
Is there any problem in the CI? |
Contributor
Author
|
Can we fix codeclimate? With the current shape is not useful : (( |
aplanas
force-pushed
the
fix_kubeadm
branch
4 times, most recently
from
8c98a23 to
9cf4035
Compare
twangboy
requested changes
Jun 14, 2019
aplanas
force-pushed
the
fix_kubeadm
branch
2 times, most recently
from
602d408 to
fc1f5e4
Compare
Contributor
Author
|
@twangboy ready for re-review |
ghost
requested a review
from 
waynew
previously approved these changes
Aug 28, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Being wholly unfamiliar with kubeadm, this looks reasonable to me.
If there's someone else who is more familiar with kubeadm who sees any problems with this, feel free to point them out. Otherwise, this looks good 👍
Contributor
Author
|
Rebased into master |
Contributor
|
@aplanas Test failures look legit |
aplanas
force-pushed
the
fix_kubeadm
branch
3 times, most recently
from
ee3a4ce to
0a295e1
Compare
aplanas
force-pushed
the
fix_kubeadm
branch
2 times, most recently
from
611b130 to
f548840
Compare
aplanas
force-pushed
the
fix_kubeadm
branch
5 times, most recently
from
b119d00 to
2a14c98
Compare
Contributor
Author
|
no failing test, re-review? |
dwoz
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add initial execution module to support the kubeadm command.
Tests written?
Yes