Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add initial module for kubeadm #53345

Merged
merged 1 commit into from
May 18, 2020
Merged

kubeadm: add initial module for kubeadm #53345

merged 1 commit into from
May 18, 2020

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Jun 3, 2019

What does this PR do?

Add initial execution module to support the kubeadm command.

Tests written?

Yes

@aplanas
Copy link
Contributor Author

aplanas commented Jun 3, 2019 •
edited
Loading

Ready for reviews

@aplanas aplanas force-pushed the fix_kubeadm branch 2 times, most recently from 383166b to e531992 Compare June 4, 2019 08:41
@cachedout cachedout mentioned this pull request Jun 4, 2019
Merged
@aplanas
Copy link
Contributor Author

aplanas commented Jun 5, 2019

Is there any problem in the CI?

@aplanas
Copy link
Contributor Author

aplanas commented Jun 5, 2019

Can we fix codeclimate? With the current shape is not useful : ((

@aplanas aplanas force-pushed the fix_kubeadm branch 4 times, most recently from 8c98a23 to 9cf4035 Compare June 7, 2019 10:01
@aplanas aplanas mentioned this pull request Jun 11, 2019
Closed
twangboy
twangboy requested changes Jun 14, 2019
View reviewed changes
salt/modules/kubeadm.py Outdated Show resolved Hide resolved
salt/modules/kubeadm.py Outdated Show resolved Hide resolved
salt/modules/kubeadm.py Show resolved Hide resolved
@aplanas aplanas force-pushed the fix_kubeadm branch 2 times, most recently from 602d408 to fc1f5e4 Compare June 14, 2019 07:54
@aplanas
Copy link
Contributor Author

aplanas commented Jul 22, 2019

@twangboy ready for re-review

@aplanas aplanas requested a review from a team as a code owner August 23, 2019 08:12
@ghost ghost requested a review from waynew August 23, 2019 08:12
waynew
waynew previously approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being wholly unfamiliar with kubeadm, this looks reasonable to me.

If there's someone else who is more familiar with kubeadm who sees any problems with this, feel free to point them out. Otherwise, this looks good 👍

@aplanas aplanas changed the base branch from develop to master October 14, 2019 11:56
@aplanas
Copy link
Contributor Author

aplanas commented Oct 14, 2019

Rebased into master

@aplanas aplanas requested a review from twangboy November 12, 2019 15:09
@dwoz
Copy link
Contributor

dwoz commented Jan 7, 2020

@aplanas Test failures look legit

@aplanas aplanas force-pushed the fix_kubeadm branch 3 times, most recently from ee3a4ce to 0a295e1 Compare January 7, 2020 12:08
@aplanas aplanas force-pushed the fix_kubeadm branch 3 times, most recently from 214c5e0 to aa9bd74 Compare April 15, 2020 11:25
@aplanas aplanas force-pushed the fix_kubeadm branch 3 times, most recently from b119d00 to 2a14c98 Compare April 17, 2020 14:47
@aplanas
Copy link
Contributor Author

aplanas commented May 15, 2020

no failing test, re-review?

@dwoz dwoz merged commit d4cfc32 into saltstack:master May 18, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@aplanas aplanas deleted the fix_kubeadm branch June 15, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@waynew waynew waynew left review comments

@twangboy twangboy Awaiting requested review from twangboy

Assignees
No one assigned
Labels
Reviewers-Assigned ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aplanas @dwoz @waynew @twangboy @Ch3LL @sagetherage