-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix salt-ssh pillar bug for state.sls_id function #53348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pushing the fix for this :) really appreciate it. any chance we can get a test added here to insure this does not regress in the future? Should be pretty easy to use the current state.sls_id tests in tests/integration/ssh/test_state.py for an idea on how to approach the test.
@Ch3LL Unfortunately I can't get integration tests working.
|
what if you add the arg |
FYI I migrated this PR from develop to neon to ensure it is included in the upcoming neon release. Let me know if this caused any issues. Thanks |
@Ch3LL |
re-run all |
@xuhcc will you rebase against master, please? |
@sagetherage Done! |
@xuhcc looks like there is a merge conflict here. |
looks like just a lint and pre-commit failure now. |
What does this PR do?
Fixes #51353
Previous Behavior
salt-ssh ignored
pillar
CLI argument during execution ofstate.sls_id
functionNew Behavior
now it should work
Tests written?
No
Commits signed with GPG?
No