Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for Amazon Linux to ip module #53351

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@waynew
Copy link
Contributor

commented Jun 3, 2019

What does this PR do?

Adds checks for Amazon Linux to the IP module. Right now it tries to say that it's RedHat 1 or RedHat 2.

What issues does this PR fix or reference?

Fixes #53171

Previous Behavior

On Amazon Linux 1 and 2 it's treated as RedHat 1 and 2.

New Behavior

On Amazon Linux 1 it's RedHat 6, and Amazon Linux 2 is RedHat 7

Tests written?

Fixes existing test

Commits signed with GPG?

Yes

Fixes #53171
@waynew waynew force-pushed the waynew:53171-fix-network-managed branch from 214c5a8 to e801afe Jun 4, 2019
@waynew

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

re-run all

@waynew waynew requested a review from Ch3LL Jun 4, 2019
@Ch3LL
Ch3LL approved these changes Jun 4, 2019
@waynew waynew merged commit 5efb670 into saltstack:2019.2.1 Jun 4, 2019
13 checks passed
13 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@waynew waynew deleted the waynew:53171-fix-network-managed branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.