Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added refs to AIX module documentation #53369

Merged
merged 21 commits into from Jun 17, 2019

Conversation

@Akm0d
Copy link
Contributor

commented Jun 4, 2019

What does this PR do?

Add ref to documentation for AIX

What issues does this PR fix or reference?

#53333

Commits signed with GPG?

Yes

@Akm0d Akm0d requested a review from bryceml Jun 4, 2019
Copy link
Contributor

left a comment

bryceml@a905c28

you have to add it to the index too.

@bryceml

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

I wasn't very through on the commit I posted above, so there might be additional changes as well.

@Akm0d

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Got it, anywhere else we might need a change? Is My description of AIX pkg correct?

@bryceml
bryceml approved these changes Jun 4, 2019
@mchugh19

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Likely part of #52368 as well

Akm0d added 5 commits Jun 4, 2019
…_docs
@Akm0d

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Likely part of #52368 as well

Looks like most of it is similar. There are some change to the index and such seem to be unique to this PR

Akm0d and others added 9 commits Jun 5, 2019
…_docs
@codecov

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #53369 into 2019.2.1 will increase coverage by 23.63%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53369       +/-   ##
=============================================
+ Coverage     13.41%   37.04%   +23.63%     
=============================================
  Files          1520     1576       +56     
  Lines        252471   269530    +17059     
  Branches      53842    57450     +3608     
=============================================
+ Hits          33862    99859    +65997     
+ Misses       215833   158417    -57416     
- Partials       2776    11254     +8478
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.65% <ø> (?)
#debian9 36.44% <ø> (?)
#proxy ?
#py2 36.84% <ø> (+23.56%) ⬆️
#py3 35.63% <ø> (+22.53%) ⬆️
#ubuntu1604 36.8% <ø> (+31.81%) ⬆️
#ubuntu1804 36.47% <ø> (?)
Impacted Files Coverage Δ
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/proxy/rest_sample.py 0% <0%> (-38.38%) ⬇️
salt/cloud/clouds/linode.py 13.58% <0%> (-36.34%) ⬇️
salt/modules/dummyproxy_service.py 46.15% <0%> (-35.9%) ⬇️
... and 1171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d806b58...0ef9892. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #53369 into 2019.2.1 will increase coverage by 23.63%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53369       +/-   ##
=============================================
+ Coverage     13.41%   37.04%   +23.63%     
=============================================
  Files          1520     1576       +56     
  Lines        252471   269530    +17059     
  Branches      53842    57450     +3608     
=============================================
+ Hits          33862    99859    +65997     
+ Misses       215833   158417    -57416     
- Partials       2776    11254     +8478
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.65% <ø> (?)
#debian9 36.44% <ø> (?)
#proxy ?
#py2 36.84% <ø> (+23.56%) ⬆️
#py3 35.63% <ø> (+22.53%) ⬆️
#ubuntu1604 36.8% <ø> (+31.81%) ⬆️
#ubuntu1804 36.47% <ø> (?)
Impacted Files Coverage Δ
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/proxy/rest_sample.py 0% <0%> (-38.38%) ⬇️
salt/cloud/clouds/linode.py 13.58% <0%> (-36.34%) ⬇️
salt/modules/dummyproxy_service.py 46.15% <0%> (-35.9%) ⬇️
... and 1171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d806b58...0ef9892. Read the comment docs.

Akm0d added 4 commits Jun 11, 2019
@garethgreenaway garethgreenaway self-requested a review Jun 17, 2019
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jun 17, 2019
@waynew
waynew approved these changes Jun 17, 2019
@Akm0d Akm0d merged commit ff7370e into saltstack:2019.2.1 Jun 17, 2019
7 of 17 checks passed
7 of 17 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py2-centos-6 running py2-centos-6...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-debian-9 running py2-debian-9...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-debian-8 running py3-debian-8...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-ubuntu-1804 running py3-ubuntu-1804...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
@Akm0d Akm0d deleted the Akm0d:aix_docs branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.