Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import #53386

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@dwoz
Copy link
Contributor

commented Jun 5, 2019

What does this PR do?

Fixes missing import in salt.transport.tcp

Tests written?

No - Prevents existing tests from raising an exception:

       Traceback (most recent call last):
         File "/tmp/kitchen/testing/salt/transport/tcp.py", line 1057, in _stream_return
       AttributeError: 'NoneType' object has no attribute 'StreamClosedError'
       Exception ignored in: <generator object _stream_return at 0x7fd535869150>

Commits signed with GPG?

Yes

@Akm0d Akm0d self-requested a review Jun 5, 2019
@Akm0d
Akm0d approved these changes Jun 5, 2019
@Ch3LL
Ch3LL approved these changes Jun 6, 2019
@garethgreenaway garethgreenaway self-requested a review Jun 6, 2019
@garethgreenaway garethgreenaway merged commit cf98b83 into saltstack:2019.2.1 Jun 6, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.