Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Stale events 53411 #53412
What does this PR do?
What issues does this PR fix or reference?
Commits signed with GPG?
dmurphy18 left a comment
The extraneous conditional
might be unneeded, since line 1272 resets to False, unless I missed the need for it, in which case let me know what I missed.
After banging my head against this for some time I think we will need to resort to a manual test.
If there is an approach I am unaware of I'm happy to explore it.
Both of those points sound accurate to me.
I would love it if we had an automated suite that roughly does what we do with the current integration suite, but instead was more like just running a salt orchestration, and we verified that each of the state result was what we expected. Basically an automated manual test suite
I would like to write tests, but according to my understanding of the test suite as it stands: