Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimaster minion hang on fire_master #53417

Open
wants to merge 3 commits into
base: 2018.3
from

Conversation

@DmitryKuzmenko
Copy link
Contributor

commented Jun 9, 2019

What does this PR do?

Fire master asynchronously in minion event handler. This makes multimaster minion to fire events in parallel to all masters to not hang if any of multiple masters stopped.

What issues does this PR fix or reference?

Fixes #50814 (ZD-3031)

Previous Behavior

Multimaster minion stops to respond until master connection timed out after a number of retries when on of masters is stopped.

New Behavior

Multimaster minion continues to work normally until at least one master is alive.

Tests written?

No. I see no easy way to test this change.

Commits signed with GPG?

Yes

@DmitryKuzmenko DmitryKuzmenko requested a review from saltstack/team-core as a code owner Jun 9, 2019
@dwoz dwoz added the Needs Testcase label Jun 10, 2019
@Ch3LL Ch3LL requested a review from dwoz Jun 14, 2019
@@ -605,7 +605,7 @@ def _read(self, timeout, callback=None):
except tornado.gen.TimeoutError:
raise tornado.gen.Return(None)

log.debug('IPC Subscriber is starting reading')

This comment has been minimized.

Copy link
@mattp-

mattp- Jun 14, 2019

Contributor

👍 this was annoying me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.