Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Workaround nox's install only flag #53485

Merged

Conversation

@s0undt3ch
Copy link
Member

commented Jun 14, 2019

What does this PR do?

To get some information from the system, which we then use to choose the appropriate static requirements file, we need to run some commands, something that nox will refuse to do if --install-only is passed.

We work around it by manually patching the value ofsession._runner.global_config.install_only for the commands that we MUST run, and only those and then we set it back to the value it had before.

For additional information about why we have to do this, please see:
theacodes/nox#181

@waynew
waynew approved these changes Jun 14, 2019
@Akm0d
Akm0d approved these changes Jun 14, 2019
To get some information from the system, which we then use to choose the
appropriate static requirements file, we need to run some commands,
something that nox will refuse to do if `--install-only` is passed.

We work around it by manually patching the value of
`session._runner.global_config.install_only` for the commands that we
MUST run, and only those and then we set it back to the value it had
before.

For additional information about why we have to do this, please see:
   theacodes/nox#181
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/fix-nox-bypass-2019.2.1 branch from 6d7efd5 to 69e1d84 Jun 17, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Thrice approved, merging.

@s0undt3ch s0undt3ch merged commit 98285f9 into saltstack:2019.2.1 Jun 18, 2019
9 of 17 checks passed
9 of 17 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has failed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
@s0undt3ch s0undt3ch deleted the s0undt3ch:hotfix/fix-nox-bypass-2019.2.1 branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.