Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syndic connection when using tcp transport #53492

Merged
merged 3 commits into from Jun 14, 2019

Conversation

@dwoz
Copy link
Contributor

commented Jun 14, 2019

What does this PR do?

Create the syndic config after we set the desired transport

Previous Behavior

Syndic was not connecting on tcp transport test runs

New Behavior

Syndic will successfully connect on tcp transport test runs

Tests written?

No - Fixes issue in existing test suite.

NOTE: We have enough code in support of our test suite that we should probably write unit tests for things like this. However we should probably move this stuff to pytest-salt and test it there.

Commits signed with GPG?

Yes

dwoz added 2 commits Jun 14, 2019
@garethgreenaway garethgreenaway self-requested a review Jun 14, 2019
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jun 14, 2019
@cmcmarrow cmcmarrow self-requested a review Jun 14, 2019
@Akm0d
Akm0d approved these changes Jun 14, 2019
@dwoz dwoz merged commit a1f4136 into saltstack:2019.2.1 Jun 14, 2019
3 of 17 checks passed
3 of 17 checks passed
jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-centos-6 running py2-centos-6...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-debian-8 running py2-debian-8...
Details
jenkins/pr/py2-debian-9 running py2-debian-9...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-ubuntu-1804 running py2-ubuntu-1804...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-debian-8 running py3-debian-8...
Details
jenkins/pr/py3-debian-9 running py3-debian-9...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-ubuntu-1804 running py3-ubuntu-1804...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/lint Python lint test has passed
Details
garethgreenaway added a commit that referenced this pull request Jun 18, 2019
Revert logging changes from #53492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.